3 replies to this topic

[watzlaf]

Hello,

I have the following code in a function:

            new Thread(
                delegate(){
                    while (true) {
                        Socket clientSocket = _listeningSocket.Accept();
                        WebHandler handler = new WebHandler(clientSocket);
                        Thread worker = new Thread(handler.handleRequest);
                        worker.Start();
                    }
                }
            ).Start();

This function is called by Main. If I start a request the worker thread is started and after a short while interrupted by the thread above(worker thread has not finished). The Accept method blocks the thread and the worker thread never gets back focus and cannot be finished. Can someone explain this behaviour?
Thx.
Watzlaf

[Magpie]

Two things I can think of 1. Did you send a packet? otherwise it will block forever. 2. Does your inline delegate cause an exception to be thrown? Ps. I wouldn't use inline delegates, I find them so confusing. I would put the .Start () on a separate line too, to make it easier to debug. Also any thread you start should probably have a try catch finally, unless you are 100% sure you wont get an exception.

[Bainesbunch]

Why does this code loop in a "while" creating new instances of the thread and then starting them. Surely if you re instantiate a thread using the same object variable it will mess with the thread created the first time through the loop. I am not a c# coder so i could be getting it all wrong. Cheers Pete.

[watzlaf]

1. Did you send a packet? otherwise it will block forever.

Yes. I sent a packet. Worker thread is started. I set breakpoints at the beginning of the worker thread function (handler.handleRequest) and the execution was stopped there.
If I do a step by step execution the worker thread can be finished.

2. Does your inline delegate cause an exception to be thrown?

There is no exception handling (try/catch or using). So if a exception will be thrown I will notice it.

Ps. I wouldn't use inline delegates, I find them so confusing.
I would put the .Start () on a separate line too, to make it easier to debug.
Also any thread you start should probably have a try catch finally, unless you are 100% sure you wont get an exception.

Normally I don't use delegate. Here I used the inline delegate to shorten the displayed code in the forum .

Why does this code loop in a "while" creating new instances of the thread and then starting them.

Surely if you re instantiate a thread using the same object variable it will mess with the thread created the first time through the loop.

I am not a c# coder so i could be getting it all wrong.

Cheers Pete.

Intention is to have a server waiting for incoming requests. Handling of the request (analyse request, create response, send response) shall be done in a separate thread so that other incoming requests can be handled (e.g. two connections at the same time).

Socket clientSocket = _listeningSocket.Accept();

blocks until an incoming connection attempt.